Closed
Conversation
6-arg version of `fs.write` doesn't support string as the 2nd arg, and similarly 5-arg version `fs.writeSync` doesn't support string as the 2nd arg. This change removes those unsupported types from the API docs.
Member
|
Should we consider it as a bug? |
Contributor
Author
We can't specify the encoding of the string with 6-arg version of |
Contributor
|
I think it's being addressed by #41677? |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6-arg version of
fs.writedoesn't support string as the 2nd arg,and similarly 5-arg version
fs.writeSyncdoesn't support stringas the 2nd arg. This change removes those unsupported types from
the API docs.
(string type is supported for 5-arg version of
fs.write, and 4-arg version offs.writeSyncand those are covered by the next entries)Examples to support the above claim: